refactor: update repository references to adm-controller#1701
refactor: update repository references to adm-controller#1701
Conversation
d69ec67 to
507e0c7
Compare
There was a problem hiding this comment.
Pull request overview
Updates this repository to reflect the rename from kubewarden/kubewarden-controller to kubewarden/adm-controller, including module/import paths, automation references, and container image naming.
Changes:
- Renames the Go module path and updates Go import paths from
github.com/kubewarden/kubewarden-controller/...togithub.com/kubewarden/adm-controller/.... - Updates release/automation configs (Updatecli + GitHub workflows) and build tooling (Makefile/Dockerfile) for the renamed repo and
controllerimage. - Refreshes docs/scripts to point at the new repository and image names.
Reviewed changes
Copilot reviewed 83 out of 85 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| updatecli/values/scms.yaml | Updatecli SCM repo renamed to adm-controller. |
| updatecli/values/artifacts.yaml | Updatecli artifact/workflow references updated for renamed repo and controller image. |
| updatecli/values.yaml | Updatecli GitHub author/email/repo updated to adm-controller. |
| updatecli/updatecli.release.d/open-release-pr.yaml | Updatecli release PR pipeline repo/name/commit metadata updated. |
| updatecli/updatecli.d/update-rust-toolchain.yaml | Updatecli SCM repo/footers updated to adm-controller. |
| updatecli/updatecli.d/update-hauler-manifest.yaml | Updatecli SCM repo/footers updated to adm-controller. |
| updatecli/updatecli.d/update-chart-deps.yaml | Updatecli SCM repo/footers updated to adm-controller. |
| updatecli/updatecli.d/go.yaml | Updatecli SCM repo/footers and PR text updated to adm-controller. |
| updatecli/DEVELOPING.md | Developer docs updated for new repo directory/link. |
| scripts/validate-hauler-manifest.sh | Hauler validation script updated for controller image naming. |
| scripts/test-sigstore-e2e.sh | E2E script references updated to renamed repo in comments/log output. |
| scripts/charts-generate-changelog-files.sh | Changelog generation script updated for new repo/image naming. |
| internal/metrics/metrics.go | Go import path updated to new module path. |
| internal/controller/utils_test.go | Go import paths updated to new module path. |
| internal/controller/suite_test.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_test.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_service.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_pdb.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_deployment.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_configmap.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_cert_secret_test.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller_cert_secret.go | Go import paths updated to new module path. |
| internal/controller/policyserver_controller.go | Go import paths updated to new module path. |
| internal/controller/policy_subreconciler_webhook_test.go | Go import paths updated to new module path. |
| internal/controller/policy_subreconciler_webhook.go | Go import paths updated to new module path. |
| internal/controller/policy_subreconciler.go | Go import paths updated to new module path. |
| internal/controller/clusteradmissionpolicygroup_controller.go | Go import paths updated to new module path. |
| internal/controller/clusteradmissionpolicy_controller.go | Go import paths updated to new module path. |
| internal/controller/cert_controller_test.go | Go import paths updated to new module path. |
| internal/controller/cert_controller.go | Go import paths updated to new module path. |
| internal/controller/admissionpolicygroup_controller.go | Go import paths updated to new module path. |
| internal/controller/admissionpolicy_controller.go | Go import paths updated to new module path. |
| internal/certs/secrets.go | Go import paths updated to new module path. |
| internal/audit-scanner/testutils/testutils.go | Go import paths updated to new module path. |
| internal/audit-scanner/scheme/scheme.go | Go import path updated to new module path. |
| internal/audit-scanner/scanner/scanner_test.go | Go import paths updated to new module path. |
| internal/audit-scanner/scanner/scanner.go | Go import paths updated to new module path. |
| internal/audit-scanner/scanner/config.go | Go import paths updated to new module path. |
| internal/audit-scanner/report/report.go | Go import paths updated to new module path. |
| internal/audit-scanner/report/policyreports_test.go | Go import paths updated to new module path. |
| internal/audit-scanner/report/policyreports_store_test.go | Go import paths updated to new module path. |
| internal/audit-scanner/report/policyreports_store.go | Go import path updated to new module path. |
| internal/audit-scanner/report/policyreports.go | Go import path updated to new module path. |
| internal/audit-scanner/report/openreports_store_test.go | Go import paths updated to new module path. |
| internal/audit-scanner/report/openreports_store.go | Go import path updated to new module path. |
| internal/audit-scanner/report/openreports.go | Go import path updated to new module path. |
| internal/audit-scanner/report/legacy_migration_test.go | Go import path updated to new module path. |
| internal/audit-scanner/policies/client_test.go | Go import paths updated to new module path. |
| internal/audit-scanner/policies/client.go | Go import paths updated to new module path. |
| go.sum | Dependency checksum updates after module path/ref updates. |
| go.mod | Go module path renamed to github.com/kubewarden/adm-controller. |
| e2e/main_test.go | E2E controller image reference updated to ghcr.io/kubewarden/controller:dev. |
| e2e/helpers_test.go | Go import paths updated to new module path. |
| e2e/clusteradmissionpolicygroup_test.go | Go import paths updated to new module path. |
| e2e/clusteradmissionpolicy_test.go | Go import paths updated to new module path. |
| e2e/admissionpolicygroup_test.go | Go import paths updated to new module path. |
| e2e/admissionpolicy_test.go | Go import paths updated to new module path. |
| docs/policy-server/README.md | Docs link updated to renamed repo. |
| docs/crds/CRD-docs-for-docs-repo.adoc | CRD docs anchors updated to new module path naming. |
| docs/controller/README.md | Controller docs updated to adm-controller naming and links. |
| cmd/controller/main.go | Go import paths updated to new module path. |
| cmd/audit-scanner/root.go | Go import paths updated to new module path. |
| charts/kubewarden-controller/values.yaml | Helm values controller image repository updated to kubewarden/controller. |
| charts/kubewarden-controller/README.md | Chart docs updated for renamed repo and controller image/artifacts. |
| charts/hauler_manifest.yaml | Hauler image and certificate identity references updated to new repo/image naming. |
| api/policies/v1/policyserver_webhook_test.go | Go import path updated to new module path. |
| api/policies/v1/policyserver_webhook.go | Go import path updated to new module path. |
| api/policies/v1/policyserver_types.go | Go import path updated to new module path. |
| api/policies/v1/factories.go | Go import path updated to new module path. |
| api/policies/v1/clusteradmissionpolicygroup_webhook_test.go | Go import path updated to new module path. |
| api/policies/v1/clusteradmissionpolicygroup_webhook.go | Go import path updated to new module path. |
| api/policies/v1/clusteradmissionpolicy_webhook_test.go | Go import path updated to new module path. |
| api/policies/v1/clusteradmissionpolicy_webhook.go | Go import path updated to new module path. |
| api/policies/v1/admissionpolicygroup_webhook_test.go | Go import path updated to new module path. |
| api/policies/v1/admissionpolicygroup_webhook.go | Go import path updated to new module path. |
| api/policies/v1/admissionpolicy_webhook_test.go | Go import path updated to new module path. |
| api/policies/v1/admissionpolicy_webhook.go | Go import path updated to new module path. |
| SECURITY-INSIGHTS.yml | Security metadata URLs updated to renamed repo. |
| README.md | Repo badges/links and component naming updated for adm-controller. |
| Makefile | Controller image build target updated to use Dockerfile.controller and controller image name. |
| Dockerfile.controller | New Dockerfile for building/publishing the controller image. |
| CONTRIBUTING.md | Release process link updated to renamed repo. |
| .github/workflows/release.yml | Release workflow component matrix and artifact names updated to controller. |
| .github/workflows/build-containers.yml | Build workflow component matrix updated to controller. |
| .github/ISSUE_TEMPLATE/3-kubewarden-release.yml | Release issue template updated for renamed repo references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| CONTROLLER_VERSION=$(grep "kubewarden/controller" <"$IMAGELIST_FILENAME" | sed "s/.*controller:\(\)/\1/g") | ||
| CONTROLLER_URL=$(gh release view "$CONTROLLER_VERSION" --repo kubewarden/adm-controller --json "url" | jq -r ".url") |
There was a problem hiding this comment.
The regex is actually correct. In sed, s/PATTERN/REPLACEMENT/ replaces the entire match, not just the capture group. \(\) is a zero-width empty group. So .*controller:\(\) matches everything up to and including controller:, and \1 (empty) replaces it, leaving the version tag untouched as unmatched remainder. It's equivalent to the simpler s/.*controller://.
echo "ghcr.io/kubewarden/controller:v1.35.0" | sed "s/.*controller:\(\)/\1/g"
v1.35.0
Update go.mod module declaration and all Go import paths from github.com/kubewarden/kubewarden-controller to github.com/kubewarden/adm-controller following the GitHub repository rename. Assisted-by: Github Copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
…ller Rename Dockerfile.kubewarden-controller to Dockerfile.controller and update all references to the container image name across the codebase. The Makefile, CI workflows, e2e tests, chart values, hauler manifest, READMEs, and changelog script are all updated to use the new image name. Assisted-by: Github Copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Update all updatecli configurations to reference the new repository name adm-controller and the new container image name controller. This covers SCM repository references, bot email/author names, container image URLs, and workflow URLs used for cosign verification. Assisted-by: Github Copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
Update all remaining GitHub repository URL and image references across SECURITY-INSIGHTS.yml, CONTRIBUTING.md, README.md, issue templates, internal docs, and scripts to reflect the repository rename from kubewarden-controller to adm-controller and the image rename from kubewarden-controller to controller. Assisted-by: Github Copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
507e0c7 to
bb6aeb2
Compare
| [](https://www.bestpractices.dev/projects/6502) | ||
| [](https://app.fossa.com/projects/custom%252B25850%252Fgithub.com%252Fkubewarden%252Fkubewarden-controller?ref=badge_shield) | ||
| [](https://scorecard.dev/viewer/?uri=github.com/kubewarden/kubewarden-controller) | ||
| [](https://scorecard.dev/viewer/?uri=github.com/kubewarden/adm-controller) |
There was a problem hiding this comment.
Need to fix OpenSSF links and report
There was a problem hiding this comment.
This files will required to use the changes from this PR to properly name container image
There was a problem hiding this comment.
This files will required to use the changes from this PR to properly name container image
Update all references to the 3 container images built by this repository to use the new adm-controller path prefix, matching the images published by CI with repository-prefix: adm-controller: ghcr.io/kubewarden/controller → ghcr.io/kubewarden/adm-controller/controller ghcr.io/kubewarden/audit-scanner → ghcr.io/kubewarden/adm-controller/audit-scanner ghcr.io/kubewarden/policy-server → ghcr.io/kubewarden/adm-controller/policy-server Policy and test images (ghcr.io/kubewarden/policies/*, tests/*) are not built here and are left unchanged. Assisted-by: Github Copilot Signed-off-by: José Guilherme Vanz <jguilhermevanz@suse.com>
bb29be3 to
9422c6b
Compare
Description
We've renamed the
kubewarden/kubewarden-controllerintokubewarden/adm-controller. This PR is part of the updates necessary to be done after this renaming.Part of #1657